Open Source Hacking
Getting your Code into a Software Release
First off I’ll premise this with the fact that this isn’t exactly a guide on how to get it done but rather my experiences with getting my own code commited, reviewed and eventually staged and on it’s way to the 0.9 release of Popcorn.js.
It all started Thursday night when I was browsing through some of the existing plugins to try and figure out the language some more so I could start working on the ticket I choose for the tumblr plugin. I was looking at the Facebook plugin when I noticed an error left over from the original writers copy and paste from the flickr plugin that read:
flickr target container doesn’t exist
Flickr container you say? Well of course, this is the facebook plugin! Anyway I found this quite humorous so I figured I would point it out on IRC for a good laugh and chuckle from everyone. Shortly afterwards though John Buckley quickly asked me to file a ticket for it, claim it and then commit said code so it could be reviewed. At first I was rather surprised because to me it seemed like it would be such a waste of everyones time for such a minor error, that I could easily just fix it anyway and there wouldn’t be a need to “waste time” with a ticket on it. John quickly said to me however that it really doesn’t matter how small the issue is, that you really need records of every change that’s made to the code so people can know why and when there were changes made. So I did and decided I would worry about it later the next day.